creates impacts app and some models #1531
Conversation
| SEQUENCE = "SEQUENCE", "Sequence" | ||
|
|
||
|
|
||
| class TreatmentPrescriptionAction(models.TextChoices): |
There was a problem hiding this comment.
List fetched from David Schmidt
| # I still can't decide if it's best for us to clone the stand geometry | ||
| # or to have a direct reference to it. I think cloning makes sense because | ||
| # it actually frees us from a lot of FK handling | ||
| stand = models.ForeignKey( |
There was a problem hiding this comment.
@lastminutediorama @pflopez this is where I have most of my questions...
I don´t think it is really useful/necessary to have a hard foreign key to the stand. The reason is that this creates friction with the stands (let's delete all stands and recreate them, if we ever need).
If we copy the stand geometry, we don't need the FK. We might have to copy some other property like stand size.
| ): | ||
| created_by = models.ForeignKey( | ||
| User, | ||
| related_name="tx_plans", |
There was a problem hiding this comment.
tx is a common abbreviation for treatment. if you don't like it, we can expand into the full name.
There was a problem hiding this comment.
LGTM! chatted about a missing name on treatment plan, but otherwise looks great!
Regarding cloning vs FK - I leave this to you and @lastminutediorama ... my gut tells me FK are better but I don't know all the work involved into maintaining that properly. We discussed some use cases which we can handle with both solutions, so from my end, do whatever its more ergonomic for future development 🎉
|
Ok, perfect. Let's merge and we see if need the FK. I don't think we will ever need it. |
No description provided.